Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style updates on toast notification #8115

Closed
kingtraceyj opened this issue Mar 17, 2021 · 0 comments · Fixed by #8165
Closed

Style updates on toast notification #8115

kingtraceyj opened this issue Mar 17, 2021 · 0 comments · Fixed by #8165
Assignees
@emyarod
Labels
component: notification type: bug 🐛

Comments

@kingtraceyj
Copy link
Member

There are a few discrepancies between toast notifications in code and in the design kit.

Currently in storybook:
Padding is 14px around icon in top left
length of toast looks to be 480px

image

Should be:
Padding should be 16px around icon
length of 288px

image (48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
component: notification type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(toast-notification): match updated spec emyarod/carbon
2 participants
@emyarod @kingtraceyj