Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text input] fully controlled toggle password icon is outside of container #7765

Closed
2 tasks
oliviaflory opened this issue Feb 9, 2021 · 0 comments · Fixed by #7799
Closed
2 tasks

[Text input] fully controlled toggle password icon is outside of container #7765

oliviaflory opened this issue Feb 9, 2021 · 0 comments · Fixed by #7799

Comments

@oliviaflory
Copy link
Contributor

oliviaflory commented Feb 9, 2021

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

When upgrading the Expressive theme components to v10.28.0 we noticed through our Percy review the Text Input fully controlled toggle password visibility variant has the eye icon outside of the text input container. This is true on the Carbon react storybook

Screen Shot 2021-02-09 at 10 19 55 AM

Is this issue related to a specific component?

https://react.carbondesignsystem.com/?path=/story/textinput--fully-controlled-toggle-password-visibility

What did you expect to happen? What happened instead? What would you like to
see changed?

I believe the icon should be inside the container, similar to Text Input Toggle Visibility variant
Screen Shot 2021-02-09 at 11 01 08 AM

https://react.carbondesignsystem.com/?path=/story/textinput--toggle-password-visibility

What browser are you working in?

What version of the Carbon Design System are you using?

v10.28.0

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

Carbon for IBM.com Expressive theme of the Carbon components

Steps to reproduce the issue

  1. Step one
  2. Step two
  3. Step three
  4. etc.

Please create a reduced test case in CodeSandbox

Additional information

  • Screenshots or code
  • Notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants