Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeSnippet: showMore should only be displayed when there are more then 15 rows #7572

Closed
1 of 2 tasks
guigueb opened this issue Jan 14, 2021 · 4 comments
Closed
1 of 2 tasks

Comments

@guigueb
Copy link
Contributor

guigueb commented Jan 14, 2021

CodeSnippet: showMore should only be displayed when there are more then 15 rows

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

When using <CodeSnippet type={'multi'}>{codeSnippet},...

If {codeSnippet} contains less than 14 rows...

  • the rows are shown and the showMore is not shown
  • this is good

If {codeSnippet} contains more then 15 rows...

  • 15 rows and the showMore button is shown
  • clicking the button shows all the rows and the show Less button
  • this is good

If {codeSnippet} contains exactly 15 rows...

  • 15 rows and the showMore button is shown
  • clicking the button shows the same 15 rows and the show Less button
  • this is not good

This shows in the latest Carbon Design System using any browser.

Steps to reproduce the issue

  1. View CodeSnippet with type='multi' in the Carbon Design System
  2. Test with 14, 15, and 16 rows
  3. Observe and click the showMore button
@guigueb
Copy link
Contributor Author

guigueb commented Jan 14, 2021

This bug is described in #7551

@guigueb
Copy link
Contributor Author

guigueb commented Jan 15, 2021

PR #7582

@guigueb
Copy link
Contributor Author

guigueb commented Feb 10, 2021

@tw15egan
I'm sorry to play the new guy card...
This has a state of waiting for maintainer response, who is that and what type of response is required?
Actually, is there a flowchart of the Carbon approval process?
How can I tell what stages there are, where I am in the process, and who to contact when in those stages?
Maybe I should post this in a slack chat...

@guigueb
Copy link
Contributor Author

guigueb commented Feb 10, 2021

PR merged - this issue is resolved.
On to https://github.com//issues/7579

@guigueb guigueb closed this as completed Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants