Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Button hasIconOnly={true} kind="danger-ghost" ...other/> has unnecessary padding #7534

Closed
2 tasks done
lee-chase opened this issue Jan 12, 2021 · 0 comments · Fixed by #7618
Closed
2 tasks done

<Button hasIconOnly={true} kind="danger-ghost" ...other/> has unnecessary padding #7534

lee-chase opened this issue Jan 12, 2021 · 0 comments · Fixed by #7618
Assignees
@emyarod
Labels
type: bug 🐛

Comments

@lee-chase
Copy link
Member

The addition of danger-ghost kind to buttons appears to have created the possibility of an icon only version. However it has padding it does not need.

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

See https://codesandbox.io/s/polished-water-w6ivv?file=/index.js and note the danger-ghost version with just an icon has additional left padding.

Additional information

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(button): remove danger ghost icon only button svg margin emyarod/carbon
2 participants
@emyarod @lee-chase