Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Toggles inside Data Tables are wrong color #7351

Closed
1 of 2 tasks
Camille-R-C opened this issue Nov 30, 2020 · 3 comments · Fixed by #7753
Closed
1 of 2 tasks

Disabled Toggles inside Data Tables are wrong color #7351

Camille-R-C opened this issue Nov 30, 2020 · 3 comments · Fixed by #7753

Comments

@Camille-R-C
Copy link

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

When inside of a Data Table, small disabled toggles are the
wrong color. This causes accessibility issues because they then fade into the
background of the table.

Is this issue related to a specific component?

Small Toggle (disabled), Data Table

What did you expect to happen? What happened instead? What would you like to
see changed?

The colors of the toggles should be different when the toggles are inside of a Data Table.

What browser are you working in?

Firefox

What offering/product do you work on?

IBM Cloud Power Virtual Server

Steps to reproduce the issue

  1. Create a Data Table with a Small Toggle as the value in one of its cells
  2. Set that Small Toggle to Disabled
  3. Run the IBM Accessibility checker tool

Please create a reduced test case in CodeSandbox

This can also be re-created on the Carbon Design System website. On the Code tab of the
DataTable page, in the live demo, replace {cell.value} with {<ToggleSmall disabled />}.

@emyarod
Copy link
Member

emyarod commented Nov 30, 2020

color token updates will be required for this fix, will await confirmation from design on the updated token value

@tw15egan
Copy link
Member

tw15egan commented Feb 4, 2021

@carbon-design-system/design any ideas on what the small toggle colors should be when disabled inside Data Table? Current:

Screen Shot 2021-02-04 at 1 20 55 PM

@aagonzales
Copy link
Member

aagonzales commented Feb 5, 2021

Hmm without changing the value of the tokens themselves I would say just pump up each disabled token to the next step. It starts to get a little close to the off colors but I think that's all we can do without introducing a new token or change a value across the board.

Pill: $disabled-02
Circle: $disabled-03

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants