Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Large loading component]: Loading has different size to defined on carbondesignsystem website #6814

Closed
1 of 2 tasks
djj-ashton opened this issue Sep 10, 2020 · 3 comments · Fixed by #7447
Closed
1 of 2 tasks

Comments

@djj-ashton
Copy link

[Large loading component]: Loading has different size to defined on carbondesignsystem website

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

The Carbon Design Website Defines the .bx--loading class as having a width/height of 88px/5.5rem.

The value defined for .bx--loading in the file packages/components/src/components/loading/_vars.scss is 10.5rem

It looks like the ultimate displayed spinner is the correct size as there is a padding of 40px (which times 2) reduces the spinner size down to 88px.

However, it does not explain the discrepancy between the .bx-loading class value defined on the website and the value for the same class used in the code.

@djj-ashton
Copy link
Author

I have noticed that the small-loading spinner has a similar issue

@emyarod
Copy link
Member

emyarod commented Sep 16, 2020

cc @carbon-design-system/design any thoughts about this discrepancy in loading spinner size?

@laurenmrice
Copy link
Member

laurenmrice commented Sep 16, 2020

The large loader should be 88px/5.5 rem and the small loader should be 16px/1rem. There should be no extra padding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants