Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips on overflow menu #6605

Closed
mitchellbernstein opened this issue Aug 3, 2020 · 4 comments
Closed

Tooltips on overflow menu #6605

mitchellbernstein opened this issue Aug 3, 2020 · 4 comments
Labels
component: overflow-menu proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡

Comments

@mitchellbernstein
Copy link

mitchellbernstein commented Aug 3, 2020

Summary

The ability to inject a tooltip on an overflow menu item, especially in a disabled state to explain why it's disabled, is not currently possible. We'd like to propose the ability to allow this. Looking for development and design input.

Justification

We need to explain to the user why they have disabled actions and how to enable this action. Otherwise, they're left in the dark not knowing how to move forward in some cases.

Desired UX and success metrics

The user is able to hover over a menu item and depending on what the design calls for, either an immediate reaction or a momentarily delayed reaction, the tooltip would appear on the side of the item.

"Must have" functionality

  • Must allow for dynamic use of tooltip (both single line and multiple line)
  • Must allow for timing control (immediate on hover for disabled items and a second of hovering before revealing the tooltip– up to the designer).

Specific timeline issues / requests

This would be ideally implemented by Q4 as our delivery to ship is September 25th.

Available extra resources

What resources do you have to assist this effort?

Can contact [email protected] as he's the dev on our team responsible for helping to implement this capability.

Examples of it looking werid and not natural:

image
image

Example of it acting as depicted in our designs:

image

@tw15egan tw15egan added component: overflow-menu proposal: open This request has gone through triaging. We're determining whether we take this on or not. and removed status: needs triage 🕵️‍♀️ labels Aug 17, 2020
@dakahn
Copy link
Contributor

dakahn commented Aug 26, 2020

The first few proposed designs could be very frustrating for people using magnification -- with the end of a potentially a very long run on sentence being quite a ways away from it's triggering element (at 300+ magnification). we should use a non-modal dialog here instead, I'd think (like your last example).

That concern aside, general accessibility guidance with this pattern is:

  • make an overflow list item's disabled state a visual affordance only (in other words, don't set disabled on the list item's HTML).
  • allow the disabled list item to be focusable by keyboard
  • have the dialog trigger on focus and persist until focus is moved
  • the dialog should announce itself via an aria-live region

@swwebster
Copy link

FWIW, this is a capability that my product would also be interested in having, as our existing (pre-Carbon) code has many instances of tooltips on disabled actions/buttons. Our dev team has created a workaround of some kind using custom Carbon components in the mean time.

Example:
image

@emyarod
Copy link
Member

emyarod commented Jan 11, 2021

#7277 provided a workaround with native tooltips but I'm not sure if we will proceed with supporting Carbon tooltips within overflow menus at the moment based on @dakahn's feedback above

@vpicone vpicone added proposal: accepted This request has gone through triaging and we are accepting PR's against it. and removed proposal: needs more research 🕵️‍♀️ proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Jun 7, 2021
@tw15egan
Copy link
Member

We are unlikely to add Tooltips to disabled items, as disabled items are inherently inaccessible to keyboard / screenreader users. @dakahn offered some workarounds, like setting a visual affordance of being disabled (but not actually passing down the disabled prop). Hope that helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: overflow-menu proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡
Projects
Archived in project
Development

No branches or pull requests

7 participants