Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAP errors with MultiSelect.Filterable #6570

Closed
kglickman opened this issue Jul 28, 2020 · 8 comments · Fixed by #6906
Closed

DAP errors with MultiSelect.Filterable #6570

kglickman opened this issue Jul 28, 2020 · 8 comments · Fixed by #6906

Comments

@kglickman
Copy link

I am seeing this with
"carbon-components": "10.14.0",
"carbon-components-react": "7.14.0",

It is also reproducible with the Carbon React storybook.

image

@liulrlr
Copy link

liulrlr commented Sep 25, 2020

@rjhenriquez Just wonder if any updates for the fix?

@kodiakhq kodiakhq bot closed this as completed in #6906 Sep 25, 2020
@xiepingp
Copy link

xiepingp commented Oct 9, 2020

@rjhenriquez, I test the MultiSelect component in https://react.carbondesignsystem.com/iframe.html?id=multiselect--filterable using Accessibility Checker, the violations are still happening, would you please take a look?
6570 - carbon

@tw15egan
Copy link
Member

tw15egan commented Oct 9, 2020

@xiepingp seems like the react website is still on 7.20.0. I think this fix is included in 7.21.0

@xiepingp
Copy link

Thanks @tw15egan for the information 😄 !

@xiepingp
Copy link

xiepingp commented Dec 14, 2020

Hi @tw15egan, I retest this issue on carbon-components-react v7.25.0, below 2 violations are still there:
-Initial DOM focus on the combobox is not set on the text input when the combobox receives focus.
-The element using 'aria-activedescendant' set to "carbon-multiselect-example-item-0" does not have its 'tabindex' attribute value set to 0 or -1.
https://react.carbondesignsystem.com/iframe.html?id=multiselect--filterable
carbon-6570

Could you please reope the issue and take a look?
Thanks!

@tw15egan
Copy link
Member

Seems like the a11y violation is only popping up when an item is selected

@tw15egan
Copy link
Member

@dakahn Seems like these are related?
#7331
IBMa/equal-access#282 (comment)

@tw15egan
Copy link
Member

tw15egan commented Feb 2, 2021

Closing this since the initial issue has been fixed. The other a11y issues will be tracked in #7331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants