Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio Tile Group outline disappear problem #6306

Closed
ZhuoyueLyu opened this issue Jun 17, 2020 · 5 comments · Fixed by #8258
Closed

Radio Tile Group outline disappear problem #6306

ZhuoyueLyu opened this issue Jun 17, 2020 · 5 comments · Fixed by #8258

Comments

@ZhuoyueLyu
Copy link

ZhuoyueLyu commented Jun 17, 2020

Hi, I'm Zhuoyue from the IBM Watson Studio UI team and am currently working on developing UI for AutoAI.

The Radio Tile Group's outline disappears under 70% Zoom or smaller. This seems to be the bug for Chrome alone, in the safari everything is fine.

Safari
image
Chrome
image

Safari
image
Chrome
image

A temporary fix we are using is to add the following code inside the tilesContainer of the respective .scss, but this only partially solves the problem. If we zoom in 67% or less, we need an even smaller outline-offset to make sure the outline shows up correctly. But under smaller outline-offset, the 110% or more zoom in will looks weird. So I think this component should be updated for this situation. Thanks!

:global(.bx--tile--is-selected){
	outline-offset: -1.5px !important;
}
@ZhuoyueLyu ZhuoyueLyu changed the title Radio Tile Grop outline disappear problem Radio Tile Group outline disappear problem Jun 17, 2020
@joshblack
Copy link
Contributor

Hey @ZhuoyueLyu! 👋 Could you share your use-case for zooming out at 67% or lower?

@ZhuoyueLyu
Copy link
Author

ZhuoyueLyu commented Jun 18, 2020

Hi, @joshblack Yeah, 67% is a little bit extreme, but currently, this bug will appear at 90% or lower. (Which is still pretty common, I guess? I'm just wondering if there is any once-all-for-all solution other then change the outline-offset 😅 )
Screen Shot 2020-06-18 at 11 42 27 AM
Screen Shot 2020-06-18 at 11 42 25 AM
Screen Shot 2020-06-18 at 11 42 22 AM

@joshblack
Copy link
Contributor

@ZhuoyueLyu yeah, it's definitely a hard one. It seems like when we go smaller than 100% that Chrome will change the outline width to 1.11111px due to sub-pixel rendering 😞 we can definitely look and see what our options are, most likely switching over to border or box-shadow.

@ZhuoyueLyu
Copy link
Author

ZhuoyueLyu commented Jun 19, 2020

@joshblack Okay, I see...agreed. I've tried the border actually, but I notice the tile will move a little bit when we switch selection between two adjacent tiles. I guess it's because the border has a certain width, which pushes the adjacent tile in the opposite direction. I haven't tried the box-shadow, maybe it will work. 😅

@andreancardona
Copy link
Contributor

@ZhuoyueLyu Thank you for your patience on this! You should see a fix here: #8258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants