Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Condensed grid] Remove 2px gutter and achieve grid division with 1px border #5956

Closed
shixiedesign opened this issue Apr 28, 2020 · 0 comments · Fixed by #6263
Closed

[Condensed grid] Remove 2px gutter and achieve grid division with 1px border #5956

shixiedesign opened this issue Apr 28, 2020 · 0 comments · Fixed by #6263

Comments

@shixiedesign
Copy link
Contributor

shixiedesign commented Apr 28, 2020

Summary

In Carbon's current grid guidance, Condensed grid is used to achieve a 2px division between grouped items (typically cards or tiles) placed on grid. However, this visual treatment is rarely found in the IBM Design Language. Even Carbon homepage and IBM Design Language homepage employs a 1px division between cards in groups. We have yet found compelling examples that uses condensed grid as-is to achieve a 2px division. Digital team (IBM.com) would like to use a 1px division in card groups as well, and the current Condensed grid implementation is blocking it.

The suggestion is to update Condensed grid to support 1px division to really enable teams to build designs already established by the Language.

Details or "Must have" functionality

Zero out the gap between items placed on grid by default. Items get full width of the columns assigned. Division between adjacent items is achieved by adding 1px border, either$ui-03 $ui-04 or $ui-05.

Proposed designs for Card groups on IBM.com

A section from the Learn page. Design come from IBM.com Reboot team (contact persons Lila Title, Shixie Shi Trofimov) and IBM.com Digital Design System team (Wonil Suh, Lara Hanlon, Olivia Flory).

On mobile, all cards stack vertically, 1px border-top $ui-03 on touching cards

image

Desktop (xlg) breakpoint alone:

learn-page-section

Comparison. More explorations exist if anyone wanna see them.

Artboard

Justification

Visual weight of a 2px division using $ui-background vs a 1px division using $ui-03 is about the same. We should unify so designers don't get confused seeing exemplifying live pages differ from tooling and guidance.

List of places where 1px division is seen on official sources exemplifying the Language:

@shixiedesign shixiedesign changed the title WIP - [Condensed grid] Remove 2px gutter and achieve grid division with 1px border-left between adjacent cards [Condensed grid] Remove 2px gutter and achieve grid division with 1px border-left between adjacent cards Apr 28, 2020
@shixiedesign shixiedesign changed the title [Condensed grid] Remove 2px gutter and achieve grid division with 1px border-left between adjacent cards [Condensed grid] Remove 2px gutter and achieve grid division with 1px border Apr 28, 2020
@alisonjoseph alisonjoseph mentioned this issue May 4, 2020
67 tasks
@alisonjoseph alisonjoseph mentioned this issue Jun 1, 2020
41 tasks
@joshblack joshblack self-assigned this Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants