Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement[helper text]: move helper text below input fields and dropdowns #5279

Closed
3 tasks done
jeanservaas opened this issue Feb 5, 2020 · 1 comment · Fixed by #5867
Closed
3 tasks done

enhancement[helper text]: move helper text below input fields and dropdowns #5279

jeanservaas opened this issue Feb 5, 2020 · 1 comment · Fixed by #5867

Comments

@jeanservaas
Copy link
Contributor

jeanservaas commented Feb 5, 2020

enhancement[helper text]: move helper text below input fields and dropdowns

Problem:

  • Product designers are having UI alignment issues with the helper text below the label

image.png


  • The stacking of the helper text under the label and the subtle color shift between the two pieces of type is fussy and not differentiated enough. $label-01 token value had to be pushed from Gray 70 to Gray 80 to make the label stand apart from the helper text; the stacking under the label also creates weird ragging

  • after a brief competitive analysis, many other best-in-practise design systems use the arrangement we are proposing including: Material, Atlassian, Patternfly and Quickbooks to name a few; not only is it more intuitive for uses but it's a better design.

  • We wanted to do this earlier but were worried about screen readers semantically reading label > help text > input in order; however you can set the screen reader order apparently to avoid that issue according to elizabeth judd this should not be a blocker.

  • Move helper text below input fields and drop down

  • Change value of $text-02 to Gray 70... both labels and helper text can now use $text-02

  • Remove right padding on helper text in mobile breakpoint

Proposed spec:

image.png

Dropdowns with helper text will function the same way, and cover the helper text when it is open... we don't believe this is a problem:

image.png

Motion specs:

Error message will animate to replace helper text; when you start to retype your input to correct the error the helper text will reappear. Material has a much better example of this than I can animate:

https://material.io/components/text-fields/#anatomy

helper_text)_example.gif

We will use our productive standard easing curves.

@tw15egan
Copy link
Member

@jeanservaas what should text-02 be changed to across all 4 themes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants