Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NumberInput] Mobile variant width sizing issue #5231

Closed
1 task done
JordanWSmith15 opened this issue Jan 31, 2020 · 3 comments · Fixed by #7919
Closed
1 task done

[NumberInput] Mobile variant width sizing issue #5231

JordanWSmith15 opened this issue Jan 31, 2020 · 3 comments · Fixed by #7919
Assignees

Comments

@JordanWSmith15
Copy link

Visual issue with mobile variant knob on number input

What package(s) are you using?

  • carbon-components-react

Detailed description

The number input mobile variant knob, when used in a form, does not size/justify well with other components (text, dropdown, ext) and causes a visual "rag"
See screen shots:
Screen Shot 2020-01-31 at 9 17 47 AM
Screen Shot 2020-01-31 at 9 18 09 AM

Is this issue related to a specific component?
NumberInput, Mobile Variant Knob
https://react.carbondesignsystem.com/?path=/story/numberinput--default

What did you expect to happen? What happened instead? What would you like to
see changed?
Component should be the same width as others when placed within a container

What browser are you working in?
Chrome, FF
What version of the Carbon Design System are you using?

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?
Maximo, March first D-cut of Application Suite

@emyarod
Copy link
Member

emyarod commented Jan 31, 2020

quick edit in storybook looks like this (depending on the width of the viewport)

image

can you create a reduced test case in Code Sandbox for this?

@priyankitshukla
Copy link

Hi @emyarod ,
Please find below link to reproduce,
https://pages.github.ibm.com/maximo-app-framework/graphite/reference-app/#/dataFormatting

Please choose third Tab Single Smart Edit to see mentioned defect.

Thanks

@emyarod
Copy link
Member

emyarod commented Feb 18, 2020

the behavior you are describing seems to be affected by the align-items rule on your container div

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants