Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript types to SideNavMenu #13606

Closed
Tracked by #12513
tay1orjones opened this issue Apr 17, 2023 · 4 comments · Fixed by #14805
Closed
Tracked by #12513

Add TypeScript types to SideNavMenu #13606

tay1orjones opened this issue Apr 17, 2023 · 4 comments · Fixed by #14805
Labels
area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐

Comments

@tay1orjones
Copy link
Member

No description provided.

@tay1orjones tay1orjones mentioned this issue Apr 17, 2023
Closed
@tay1orjones tay1orjones added status: help wanted 👐 role: dev 🤖 hacktoberfest See https://hacktoberfest.com/ area: typescript needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. labels Apr 17, 2023
@Nirajsah
Copy link
Contributor

Nirajsah commented Oct 6, 2023

i can do this

@Nirajsah
Copy link
Contributor

Nirajsah commented Oct 6, 2023 •
edited
Loading

umm, i am already done with the work.

@Nirajsah
Copy link
Contributor

Nirajsah commented Oct 6, 2023

Screenshot 2023-10-06 at 1 57 47 PM

i ran yarn install and was running yarn build when i got this error
i tried installing an npm packgage '@types/carbon__icons-react'
can anyone help me with this

@Nirajsah
Copy link
Contributor

Nirajsah commented Oct 6, 2023

TypeScript is throwing errors because the icons-react components lack type definitions, and TypeScript requires types for compatibility. It appears that the entire icons-react component library needs to be converted to TypeScript to resolve this issue.

@Nirajsah Nirajsah mentioned this issue Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐
Projects
Initial TypeScript Support
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(component): add SideNavMenu.tsx component Nirajsah/carbon
2 participants
@tay1orjones @Nirajsah