Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript types to Button, ButtonSkeleton, DangerButton, ButtonSet #13229

Closed
Tracked by #12513
tw15egan opened this issue Feb 24, 2023 · 4 comments · Fixed by #13811
Closed
Tracked by #12513

Add TypeScript types to Button, ButtonSkeleton, DangerButton, ButtonSet #13229

tw15egan opened this issue Feb 24, 2023 · 4 comments · Fixed by #13811
Assignees

Comments

@tw15egan
Copy link
Collaborator

No description provided.

@DavidChristiansen
Copy link

DavidChristiansen commented Mar 1, 2023

Carbon React v1.23.1 is broken without these types. Please fix.

TS2305: Module '"@carbon/react"' has no exported member 'ActionableNotification'.
  > 3 | import { InlineLoading, ActionableNotification } from '@carbon/react';

@tay1orjones
Copy link
Member

tay1orjones commented Mar 21, 2023

@DavidChristiansen You’ll need to add a // @ts-ignore above the line where you import the component until all the components have types provided. #13228

@lewandom
Copy link
Contributor

lewandom commented May 4, 2023

@tw15egan @tay1orjones I'd like to take this one next on my plate.

@lewandom
Copy link
Contributor

lewandom commented May 8, 2023

Waiting on #13735 before pushing a PR for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants