Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon content switcher: add implementation #12461

Closed
5 tasks
Tracked by #6982
tay1orjones opened this issue Nov 1, 2022 · 3 comments
Closed
5 tasks
Tracked by #6982

Icon content switcher: add implementation #12461

tay1orjones opened this issue Nov 1, 2022 · 3 comments
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: design ✏️ role: dev 🤖 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Milestone
2023 Q2

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Nov 1, 2022 •
edited by sstrubberg
Loading

This issue is to contain the primary development implementation items for the Icon content switcher

The spec and more info is in the parent issue, #6982

Open Questions

  • Is this possible/correct with the current a11y makeup of ContentSwitcher?
  • If a11y modifications are needed (changing roles, etc), does this need to be a separate export?
  • Can we make these changes without a breaking change? (experimental if so)

Tasks

  • Review the above open questions against the POC with CAG
  • Based on the outcome of POC and CAG review, implement Icon content switcher
@aagonzales aagonzales mentioned this issue Nov 29, 2022
Closed
@sstrubberg sstrubberg added this to the 2023 Q1 milestone Dec 1, 2022
@sstrubberg sstrubberg added type: enhancement 💡 version: 11 Issues pertaining to Carbon v11 proposal: accepted This request has gone through triaging and we are accepting PR's against it. package: @carbon/react @carbon/react adopter: PAL Work-stream that directly helps a Pattern & Asset Library. adopter: DSAG labels Dec 1, 2022
@tay1orjones tay1orjones added the planning: umbrella Umbrella issues, surfaced in Projects views label Dec 7, 2022
@tay1orjones tay1orjones assigned tw15egan and unassigned tw15egan Mar 9, 2023
@laurenmrice
Copy link
Member

@tw15egan Here is the final design spec #12855

@sstrubberg sstrubberg modified the milestones: 2023 Q1, 2023 Q2 Apr 5, 2023
@sstrubberg sstrubberg removed the planning: umbrella Umbrella issues, surfaced in Projects views label Apr 11, 2023
@francinelucca
Copy link
Collaborator

@tw15egan we see #13378 is merged in, are we good to close this issue or is there any outstanding tasks here? do we need to do an a11y review to close this out?

@tw15egan
Copy link
Member

No a11y violations when testing, and the screenreader was working as expected. Closing as complete 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: design ✏️ role: dev 🤖 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Projects
Design System
Archived in project
Roadmap
Archived in project
Milestone
2023 Q2
Development

No branches or pull requests
5 participants
@tay1orjones @tw15egan @sstrubberg @francinelucca @laurenmrice