Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate isFluid prop #12003

Closed
Tracked by #5416
tay1orjones opened this issue Aug 24, 2022 · 3 comments
Closed
Tracked by #5416

Deprecate isFluid prop #12003

tay1orjones opened this issue Aug 24, 2022 · 3 comments
Assignees

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Aug 24, 2022

Discussed in #11971 (comment)

What should we do with the existing isFluid props out there? Deprecate them with a note to use the new component could be a good first step.

I think that makes sense. Once this is merged (or included in this PR), we can mark the isFluid prop as deprecated, noting that the new variant is available as a standalone component.

@tw15egan
Copy link
Member

Looking at this now, it seems like isFluid is using context to set whether the control is inside a FluidForm or not. I don't think anything needs to be done as is, there is no isFluid prop being used inside TextInput, just the context references. I don't think there is much we can do until V12, where we just remove these references from TextInput and simplify the FluidForm logic to just always have that class (cds--form--fluid)

@tw15egan
Copy link
Member

tw15egan commented Aug 25, 2022

However, this did make me realize that our current implementation won't work as is, as each FluidTextnput is creating its own Form wrapper. I will make some changes to the original PR (#11971)

@tay1orjones
Copy link
Member Author

That makes sense, I'll close this one

@tay1orjones tay1orjones closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants