Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Should TextInput inline invalidMessage appear somewhere in the DOM? #10234

Closed
1 task done
lee-chase opened this issue Dec 6, 2021 · 3 comments · Fixed by #12231
Closed
1 task done

[Question]: Should TextInput inline invalidMessage appear somewhere in the DOM? #10234

lee-chase opened this issue Dec 6, 2021 · 3 comments · Fixed by #12231

Comments

@lee-chase
Copy link
Member

Question for Carbon

The TextInput when used with inline, invalidMessage and Invalid does not place the invalid message anywhere in the DOM. Is this correct it? The internal design for https://pages.github.ibm.com/cdai-design/pal/patterns/edit#inline-edit shows this below the text, another possibility would be to surface this data fro the error/invalid icon.

Code of Conduct

@tay1orjones
Copy link
Member

@lee-chase Interesting observation! I'm not sure on this. I looked through all our docs on the website and didn't see anything specifically for invalidMessage on inline TextInput.

This code was updated recently in #8806, but even there it appears the invalidMessage was previously conditionally rendered when not inline

@carbon-design-system/design @johnbister do you have any thoughts on this?

@tay1orjones
Copy link
Member

@johnbister let me know if I'm off mark, but it sounds like we'd probably want it to operate the same way as the non-inline version - The error message would display next to the text input, replacing any helper text that was previously there:

help.text.should.be.replaced.with.invalid.text.mov

@tay1orjones tay1orjones added type: bug 🐛 severity: 2 https://ibm.biz/carbon-severity and removed type: question ❓ labels Dec 7, 2021
@johnbister
Copy link
Contributor

@tay1orjones that sounds right to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants