Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Pressing the escape key wont close composed modal #10193

Closed
2 tasks done
Tracked by #10316
RowinRuizendaal opened this issue Nov 30, 2021 · 0 comments · Fixed by #11609
Closed
2 tasks done
Tracked by #10316

[Bug]: Pressing the escape key wont close composed modal #10193

RowinRuizendaal opened this issue Nov 30, 2021 · 0 comments · Fixed by #11609
Assignees
@tw15egan
Labels
component: modal package: react carbon-components-react severity: 2 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@RowinRuizendaal
Copy link

Package

carbon-components, carbon-components-react

Browser

Chrome

Package version

10.45.0

Description

The composed modal won't close when you hit the escape key when you don't have any focus elements within the modal

CodeSandbox example

https://codesandbox.io/s/dry-shadow-7o0s7?file=/src/index.js

Steps to reproduce

  1. Open the modal with the button
  2. De-focus the input field (by pressing out of the textInput)
  3. Hit the escape button
  4. The modal does not close

Code of Conduct
@RowinRuizendaal RowinRuizendaal changed the title [Bug]: Pressing escape key wont close composed modal [Bug]: Pressing the escape key wont close composed modal Nov 30, 2021
@joshblack joshblack mentioned this issue Jan 4, 2022
Closed
46 tasks
@tw15egan tw15egan mentioned this issue Jun 13, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #11609 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

Labels
component: modal package: react carbon-components-react severity: 2 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ComposedModal): close modal with esc key when no element has focus tw15egan/carbon
3 participants
@joshblack @tw15egan @RowinRuizendaal