fix(grid): moved vertical spacing to col (#4960)

* fix(condensed-grid): moved vertical spacing to col * chore(grid): updating snapshot Co-authored-by: Alessandra Davila <[email protected]> Co-authored-by: Josh Black <[email protected]>
carbon-design-system · Jan 14, 2020 · ed368b1 · ed368b1
1 parent a99142e
commit ed368b1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/packages/components/src/globals/grid/__tests__/__snapshots__/grid-test.js.snap b/packages/components/src/globals/grid/__tests__/__snapshots__/grid-test.js.snap
@@ -115,11 +115,9 @@ em {
   margin-right: -1rem;
   margin-left: -1rem; }
 
-.bx--grid--condensed .bx--row:not(:last-of-type) {
-  margin-bottom: 0.125rem; }
-
-.bx--row--condensed + .bx--row--condensed {
-  margin-top: 0.125rem; }
+.bx--grid--condensed [class*='bx--col'] {
+  padding-top: 0.0625rem;
+  padding-bottom: 0.0625rem; }
 
 .bx--col {
   width: 100%;

diff --git a/packages/grid/scss/_mixins.scss b/packages/grid/scss/_mixins.scss
@@ -320,12 +320,9 @@ $carbon--aspect-ratios: ((16, 9), (2, 1), (4, 3), (1, 1), (1, 2));
     @include carbon--make-row();
   }
 
-  .#{$prefix}--grid--condensed .#{$prefix}--row:not(:last-of-type) {
-    margin-bottom: $condensed-gutter;
-  }
-
-  .#{$prefix}--row--condensed + .#{$prefix}--row--condensed {
-    margin-top: $condensed-gutter;
+  .#{$prefix}--grid--condensed [class*='#{$prefix}--col'] {
+    padding-top: $condensed-gutter / 2;
+    padding-bottom: $condensed-gutter / 2;
   }
 
   @include carbon--make-grid-columns($breakpoints, $grid-gutter);