fix(button): set aria-pressed to props.isSelected for icon-only ghost (…

…#7900) * fix(button): set aria-pressed to props.isSelected for icon-only ghost * test: update snapshots Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
carbon-design-system · Feb 25, 2021 · e5cb20c · e5cb20c
1 parent 0310add
commit e5cb20c
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 0 deletions.
diff --git a/packages/react/src/components/Button/Button.js b/packages/react/src/components/Button/Button.js
@@ -70,6 +70,7 @@ const Button = React.forwardRef(function Button(
   let otherProps = {
     disabled,
     type,
+    'aria-pressed': hasIconOnly && kind === 'ghost' ? isSelected : null,
   };
   const anchorProps = {
     href,

diff --git a/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap b/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
@@ -2060,6 +2060,7 @@ exports[`DataTable should render 1`] = `
                       type="button"
                     >
                       <button
+                        aria-pressed={null}
                         className="bx--btn bx--btn--primary"
                         disabled={false}
                         onClick={[MockFunction]}
@@ -2132,6 +2133,7 @@ exports[`DataTable should render 1`] = `
                       type="button"
                     >
                       <button
+                        aria-pressed={null}
                         className="bx--btn bx--btn--primary"
                         disabled={false}
                         onClick={[MockFunction]}
@@ -2204,6 +2206,7 @@ exports[`DataTable should render 1`] = `
                       type="button"
                     >
                       <button
+                        aria-pressed={null}
                         className="bx--btn bx--btn--primary"
                         disabled={false}
                         onClick={[MockFunction]}
@@ -2262,6 +2265,7 @@ exports[`DataTable should render 1`] = `
                     type="button"
                   >
                     <button
+                      aria-pressed={null}
                       className="bx--batch-summary__cancel bx--btn bx--btn--primary"
                       disabled={false}
                       onClick={[Function]}
@@ -2515,6 +2519,7 @@ exports[`DataTable should render 1`] = `
                 type="button"
               >
                 <button
+                  aria-pressed={null}
                   className="bx--btn bx--btn--sm bx--btn--primary"
                   disabled={false}
                   onClick={[MockFunction]}
@@ -3066,6 +3071,7 @@ exports[`DataTable sticky header should render 1`] = `
                       type="button"
                     >
                       <button
+                        aria-pressed={null}
                         className="bx--btn bx--btn--primary"
                         disabled={false}
                         onClick={[MockFunction]}
@@ -3138,6 +3144,7 @@ exports[`DataTable sticky header should render 1`] = `
                       type="button"
                     >
                       <button
+                        aria-pressed={null}
                         className="bx--btn bx--btn--primary"
                         disabled={false}
                         onClick={[MockFunction]}
@@ -3210,6 +3217,7 @@ exports[`DataTable sticky header should render 1`] = `
                       type="button"
                     >
                       <button
+                        aria-pressed={null}
                         className="bx--btn bx--btn--primary"
                         disabled={false}
                         onClick={[MockFunction]}
@@ -3268,6 +3276,7 @@ exports[`DataTable sticky header should render 1`] = `
                     type="button"
                   >
                     <button
+                      aria-pressed={null}
                       className="bx--batch-summary__cancel bx--btn bx--btn--primary"
                       disabled={false}
                       onClick={[Function]}
@@ -3521,6 +3530,7 @@ exports[`DataTable sticky header should render 1`] = `
                 type="button"
               >
                 <button
+                  aria-pressed={null}
                   className="bx--btn bx--btn--sm bx--btn--primary"
                   disabled={false}
                   onClick={[MockFunction]}

diff --git a/...ages/react/src/components/DataTable/__tests__/__snapshots__/TableBatchAction-test.js.snap b/...ages/react/src/components/DataTable/__tests__/__snapshots__/TableBatchAction-test.js.snap
@@ -29,6 +29,7 @@ exports[`DataTable.TableBatchAction should render 1`] = `
     type="button"
   >
     <button
+      aria-pressed={null}
       className="custom-class bx--btn bx--btn--primary"
       disabled={false}
       tabIndex={0}

diff --git a/...ges/react/src/components/DataTable/__tests__/__snapshots__/TableBatchActions-test.js.snap b/...ges/react/src/components/DataTable/__tests__/__snapshots__/TableBatchActions-test.js.snap
@@ -39,6 +39,7 @@ exports[`DataTable.TableBatchActions should render 1`] = `
           type="button"
         >
           <button
+            aria-pressed={null}
             className="bx--batch-summary__cancel bx--btn bx--btn--primary"
             disabled={false}
             onClick={[MockFunction]}
@@ -93,6 +94,7 @@ exports[`DataTable.TableBatchActions should render 2`] = `
           type="button"
         >
           <button
+            aria-pressed={null}
             className="bx--batch-summary__cancel bx--btn bx--btn--primary"
             disabled={false}
             onClick={[MockFunction]}

diff --git a/packages/react/src/components/ModalWrapper/__snapshots__/ModalWrapper-test.js.snap b/packages/react/src/components/ModalWrapper/__snapshots__/ModalWrapper-test.js.snap
@@ -36,6 +36,7 @@ exports[`ModalWrapper should render 1`] = `
       type="button"
     >
       <button
+        aria-pressed={null}
         className="btn-trigger bx--btn bx--btn--primary"
         disabled={false}
         onClick={[Function]}
@@ -171,6 +172,7 @@ exports[`ModalWrapper should render 1`] = `
                   type="button"
                 >
                   <button
+                    aria-pressed={null}
                     className="bx--btn bx--btn--secondary"
                     disabled={false}
                     onClick={[Function]}
@@ -192,6 +194,7 @@ exports[`ModalWrapper should render 1`] = `
                 type="button"
               >
                 <button
+                  aria-pressed={null}
                   className="bx--btn bx--btn--primary"
                   disabled={false}
                   onClick={[Function]}