fix(checkbox-skeleton): apply skeleton class to checkbox (#4923)

carbon-design-system · Jan 13, 2020 · d05cb9a · d05cb9a
1 parent f6f040e
commit d05cb9a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/packages/components/src/components/checkbox/_checkbox.scss b/packages/components/src/components/checkbox/_checkbox.scss
@@ -185,6 +185,17 @@
   .#{$prefix}--checkbox-label[data-contained-checkbox-state='mixed'][data-contained-checkbox-disabled='true']::before {
     background-color: $disabled-02;
   }
+
+  //-----------------------------------------------
+  // Skeleton
+  //-----------------------------------------------
+
+  .#{$prefix}--checkbox-label-text.#{$prefix}--skeleton {
+    @include skeleton;
+    width: rem(100px);
+    height: $spacing-05;
+    margin: auto 0;
+  }
 }
 
 @include exports('checkbox') {

diff --git a/packages/react/src/components/Checkbox/Checkbox-test.js b/packages/react/src/components/Checkbox/Checkbox-test.js
@@ -163,7 +163,7 @@ describe('CheckboxSkeleton', () => {
       });
 
       it('has the expected classes', () => {
-        expect(label.hasClass(`${prefix}--checkbox-label`)).toEqual(true);
+        expect(label.hasClass(`${prefix}--checkbox-label-text`)).toEqual(true);
         expect(label.hasClass(`${prefix}--skeleton`)).toEqual(true);
       });
     });

diff --git a/packages/react/src/components/Checkbox/Checkbox.Skeleton.js b/packages/react/src/components/Checkbox/Checkbox.Skeleton.js
@@ -17,10 +17,11 @@ const CheckboxSkeleton = ({ className, ...rest }) => (
     className={cx(
       `${prefix}--form-item`,
       `${prefix}--checkbox-wrapper`,
+      `${prefix}--checkbox-label`,
       className
     )}
     {...rest}>
-    <span className={`${prefix}--checkbox-label ${prefix}--skeleton`} />
+    <span className={`${prefix}--checkbox-label-text ${prefix}--skeleton`} />
   </div>
 );