Skip to content

Commit

Permalink
fix(checkbox): update reset mixin, apply reset mixin to checkbox styl…
Browse files Browse the repository at this point in the history
…es (#4146)

* fix(checkbox): update reset mixin, apply reset mixin to checkbox styles

* fix(checkbox): apply PR feedback

* docs: undo changes to sass.md

* docs(checkbox): update comments

* fix(checkbox): update style arrangement

* fix(checkbox): apply PR feedback to style updates

* fix(checkbox): move style block
  • Loading branch information
jendowns authored and abbeyhrt committed Oct 22, 2019
1 parent d4a6304 commit 5f540ab
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions packages/components/src/components/checkbox/_checkbox.scss
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
.#{$prefix}--checkbox-label {
@include reset;
@include type-style('body-short-01');

line-height: 1.5rem;
position: relative;
display: flex;
Expand All @@ -59,9 +58,14 @@
user-select: none;
}

// Required because `$css--reset: true` cannot currently apply to this `::before` and `::after`
.#{$prefix}--checkbox-label::before,
.#{$prefix}--checkbox-label::after {
box-sizing: border-box;
}

// Spacing for presentational checkbox
.#{$prefix}--checkbox-label::before {
box-sizing: border-box;
content: '';

// According to the spec, we'll want the bounding box for our checkbox to
Expand All @@ -88,11 +92,12 @@
// Create the appearance of the check in the `after` pseudo-element
.#{$prefix}--checkbox-label::after {
content: '';

position: absolute;
left: rem(6px);
top: rem(8px);
width: rem(7px);
height: rem(3px);
width: rem(9px);
height: rem(5px);
background: none;
border-left: 2px solid $inverse-01;
border-bottom: 2px solid $inverse-01;
Expand Down

0 comments on commit 5f540ab

Please sign in to comment.