Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v11 banner #4169

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Conversation

thyhmdo
Copy link
Member

@thyhmdo thyhmdo commented Jul 10, 2024

Closes #4112

Removed v11 notifications

Additional changes

  • Color usage tab
    -- Kept the migration link in the Usage tab
    -- Removed the migration note of v10

@thyhmdo thyhmdo self-assigned this Jul 10, 2024
@thyhmdo thyhmdo requested review from a team as code owners July 10, 2024 22:21
Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 8:44pm

Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thy! Looks good 🔥

Just one minor point and one doubt:

  • I think we missed removing the v11 inline notification callout in the Popover component.
Screenshot 2024-07-11 at 11 53 34 AM

(Doubt:)

  • I saw "Tabs" mentioned in the issue, but I can't find the v11 callout under that component.

image


  • There's only one inline notification under the Tab usage component. I'm not sure if the "Updates for grid alignment" are available now or not. If so, we can update that message with the latest changes. (This can be handled separately by creating another issue, but I just wanted to confirmed that since I noticed it while reviewing this PR.)
Screenshot 2024-07-11 at 11 53 11 AM

@laurenmrice
Copy link
Member

I saw "Tabs" mentioned in the issue, but I can't find the v11 callout under that component.

@Kritvi-bhatia17 @thyhmdo Tracey removed the Tabs v11 notification at the top of the page in her recent Tab component docs PR that was merged, so that is why the banner is not there. I accidentally marked her in the issue as having removed the Notification component v11 banner, but that was incorrect because it was the Tabs component. I changed it back in the issue to be accurate. So this looks fine to me.

There's only one inline notification under the Tab usage component. I'm not sure if the "Updates for grid alignment" are available now or not. If so, we can update that message with the latest changes.

I would keep this notification about grid-aware tabs for now. We need to follow up with Alison to see if grid-aware tabs are in the code yet. I know some issues and PRs have been closed around this enhancement, but it would be good to double-check with her before removing it.

@Kritvi-bhatia17
Copy link
Contributor

Oh sounds good @laurenmrice, thanks for clarifying. ❤️

@Kritvi-bhatia17
Copy link
Contributor

Hi, sorry if I missed any updates, but could you confirm if we are removing the inline notification from the Popover component?

  • I think we missed removing the v11 inline notification callout in the Popover component.
Screenshot 2024-07-11 at 11 53 34 AM

@laurenmrice
Copy link
Member

@Kritvi-bhatia17 Yes, Popover still needs to have its banner removed.

Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thy!! 🔥

@kodiakhq kodiakhq bot merged commit 2c0a68a into carbon-design-system:main Jul 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v11 notifications] remove v11 related notifications on the website
5 participants