Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: Style tab #3827

Closed
3 tasks
Tracked by #13521
laurenmrice opened this issue Dec 4, 2023 · 0 comments · Fixed by #3971
Closed
3 tasks
Tracked by #13521

Tabs: Style tab #3827

laurenmrice opened this issue Dec 4, 2023 · 0 comments · Fixed by #3971
Assignees
@kingtraceyj
Labels
component: tabs role: design ✏️ type: a11y ♿ type: docs 📖 type: enhancement 💡

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Dec 4, 2023 •
edited
Loading

Ref discussion: Original issue
Ref boxnote: Style tab PDF a11y comments

Acceptance criteria

  • Update the Tabs documentation on the Style tab on the website with a11y comments and using the new content template.

Style tab

Color (enabled states)

  • Consider adding the tabpanel container to the images and the styles to the structured lists.

Interactive states

  • Need to clarify: Focus, is this an a11y violation with the selected state + focus? There is a text weight change and a color change to make the text semibold instead of regular on the selected state and its text color is darker.
  • Scrollable states: The chevron button does not get a focus state.
@laurenmrice laurenmrice mentioned this issue Dec 4, 2023
Open
@sstrubberg sstrubberg added this to the 2024 Q1 milestone Feb 7, 2024
@kingtraceyj kingtraceyj self-assigned this Mar 1, 2024
@kingtraceyj kingtraceyj mentioned this issue Mar 14, 2024
Merged
@laurenmrice laurenmrice mentioned this issue Mar 20, 2024
Closed
@laurenmrice laurenmrice modified the milestones: 2024 Q1, 2024 Q2 Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingtraceyj kingtraceyj

Labels
component: tabs role: design ✏️ type: a11y ♿ type: docs 📖 type: enhancement 💡
Projects
Design System
Archived in project
Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ally updates for tabs style kingtraceyj/carbon-website
3 participants
@sstrubberg @kingtraceyj @laurenmrice