Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pattern] status indicator content fixes #2430

Closed
laurenmrice opened this issue Jun 29, 2021 · 8 comments · Fixed by #2436
Closed

[pattern] status indicator content fixes #2430

laurenmrice opened this issue Jun 29, 2021 · 8 comments · Fixed by #2436

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Jun 29, 2021

[pattern] status indicator fixes

Content issues:

The Security team pointed out that their guidance around data decorator components directly conflicts with some of what was in the shape status indicator guidance. Their shape status indicators are widely deployed in product and this discrepancy will cause confusion. Changing their shapes to conform to our guidance would also be very costly. We've decided to fold in their risk/severity scale shape indicators into our shape indicator lexicon as they are.

Security guidance links:

https://ibm.box.com/s/mb2dwp56k4rvgl50kwr9tniuqlpbpis7
https://ibm-security.carbondesignsystem.com/?path=/story/components-security-decorator--icons

To do:

image

  • @vpicone we need to add three status shapes into the table I will give you the svgs and the hex

image

  • We need to update the table content in the YAML file (I have content @vpicone if you open the PR and fix the tables, @jeanservaas can update the YAML in the issue)

  • @jeanservaas needs to update the attached images to reflect the real Security product UI (Including the legend image, it's an incorrect example of a legend).

Full new status shape table @cameroncalder for approval

Status icons_Update

  • We also have to update the gray in the status palette

image


- Images to fix:

Screen Shot 2021-06-29 at 12 25 27 PM

Screen Shot 2021-06-29 at 12 17 16 PM

Screen Shot 2021-06-29 at 12 17 34 PM

@thyhmdo thyhmdo self-assigned this Jun 29, 2021
@jeanservaas jeanservaas changed the title [pattern] status indicator images [pattern] status indicator fixes Jun 30, 2021
@jeanservaas jeanservaas added impact: high 😱 Affects all users severity: 4 https://ibm.biz/carbon-severity labels Jun 30, 2021
@mjabbink
Copy link
Contributor

@vpicone This is a high-priority update to avoid mass confusion.

@mjabbink
Copy link
Contributor

Table alignment and grid fixes a must.

@vpicone
Copy link
Contributor

vpicone commented Jul 1, 2021

Let me know whenever the content is ready, I can update the yaml and add the images.

@mjabbink
Copy link
Contributor

mjabbink commented Jul 1, 2021

@vpicone The content is ready for icon update and color updates. @jeanservaas can confirm but those are Ready to Go Cotton-Eyed Joe.

Grid/Table alignments can happen next sprint I reckon.

@mjabbink
Copy link
Contributor

mjabbink commented Jul 1, 2021

Content is already done and provided above @vpicone

@jeanservaas
Copy link
Contributor

@vpicone

Here are the new svgs, there are screen grabs of where they go in the tables above.

Status icons updates

Caution major colors

image

Light theme filled Caution major:

  • Stroke, orange 60, Hex # BA4E00
  • Fill, orange 40, Hex # FF832B
  • exclamation glyph, black # 000000

Dark theme filled Caution major:

  • Stroke, orange 40, Hex # FF832B
  • Fill, orange 40, Hex # FF832B
  • exclamation glyph, black # 000000

Caution minor colors

image

Light theme filled Caution minor:

  • Stroke, yellow 60, Hex # 8E6A00
  • Fill, yellow 30, Hex # F1C21B
  • exclamation glyph, black # 000000

Dark theme filled Caution minor:

  • Stroke, yellow 30, Hex # F1C21B
  • Fill, yellow 30, Hex # F1C21B
  • exclamation glyph, black # 000000

Status shape updates

Critical severity color

image

Light theme Critical severity:

  • Fill, red 60, Hex # DA1E28

Dark theme Critical severity:

  • Fill, red 50, Hex # FA4D56

High severity color

image

Light theme High severity:

  • Fill, red 60, Hex # DA1E28

Dark theme High severity:

  • Fill, red 50, Hex # FA4D56

Medium severity colors

image

Light theme High severity:

  • Stroke, orange 60, # BA4E00
  • Fill, orange 40, Hex # FF832B

Dark theme High severity:

  • Stroke, orange 40, Hex # FF832B
  • Fill, orange 40, Hex # FF832B

Low severity colors

image

Light theme Low severity:

  • Stroke, yellow 60, # 8E6A00
  • Fill, yellow 30, Hex # F1C21B

Dark theme Low severity:

  • Stroke, yellow 30, Hex # F1C21B
  • Fill, yellow 30, Hex # F1C21B

New_status_assets.zip

@jeanservaas
Copy link
Contributor

@vpicone here are the image updates

names are the same so they should pop right in

image_updates.zip

@jeanservaas jeanservaas changed the title [pattern] status indicator fixes [pattern] status indicator content fixes Jul 2, 2021
@vpicone
Copy link
Contributor

vpicone commented Jul 2, 2021

@jeanservaas need the token and usage content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants