Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Button guidance and image refinements #2142

Closed
janchild opened this issue Feb 17, 2021 · 1 comment
Closed

[docs] Button guidance and image refinements #2142

janchild opened this issue Feb 17, 2021 · 1 comment
Labels
component: button role: visual 🎨 type: docs 📖

Comments

@janchild
Copy link
Contributor

janchild commented Feb 17, 2021 •
edited
Loading

This issue is to capture work needed for the Button component guidance.

  • Add a new section that covers Button relationships and hierarchy
  • Conduct an image review to make sure button placement order is correct and that the guidance is strong. with exceptions clearly marked.

https://ibm-studios.slack.com/archives/GNU2PE9NU/p1613577764000500
https://ibm-studios.slack.com/archives/GNU2PE9NU/p1612973956000600
https://ibm-studios.slack.com/archives/GNU2PE9NU/p1612975378001300

Here are some screenshots of questions that this update should answer.

image

image

image

image
@janchild janchild mentioned this issue Feb 17, 2021
Merged
@aagonzales aagonzales mentioned this issue Mar 5, 2021
Closed
87 tasks
@aagonzales
Copy link
Member

aagonzales commented Mar 9, 2021 •
edited
Loading

Tacking onto this issue:

  • Add guidance on two line of text in button and icon alignment.
  • See conversation in slack.
    image

This is the as-is alignment in code.
image

@laurenmrice laurenmrice mentioned this issue Mar 19, 2021
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: button role: visual 🎨 type: docs 📖
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aagonzales @sstrubberg @laurenmrice @janchild