Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs live demo is misleading #2125

Closed
Tracked by #7860
andrea-island opened this issue Nov 20, 2020 · 1 comment · Fixed by #2157
Closed
Tracked by #7860

Breadcrumbs live demo is misleading #2125

andrea-island opened this issue Nov 20, 2020 · 1 comment · Fixed by #2157

Comments

@andrea-island
Copy link

The live demo for the Breadcrumbs shows the current page in the breadcrumb and a trailing slash by default. The default, according to the documentation, is for the current page to not be in the breadcrumb. And when the current page is shown in the breadcrumb, there should not be a trailing slash.

The ask for the live demo and the Breadcrumb implementation (to avoid developer confusion and inconsistencies):

  1. don't show the current page by default + do show the trailing slash by default
  2. allow adding the current page as an option + do not show the trailing slash when this option is selected
@dakahn
Copy link
Contributor

dakahn commented Nov 20, 2020

Having the default live example match the default design experience makes sense to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants