Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Date picker] - Background overrides #423

Closed
ivanbachev opened this issue Apr 19, 2021 · 4 comments
Closed

[Date picker] - Background overrides #423

ivanbachev opened this issue Apr 19, 2021 · 4 comments

Comments

@ivanbachev
Copy link

Detailed description

The Date picker open state component in the Sketch library is not constructed in a way to allow overriding the “Previous month” and “Next month” buttons backgrounds. As a result there is no way to properly set the open state with a grey background to match the input background.

Screen Shot 2021-04-16 at 9 07 43

What version of the Carbon Design System Kit are you using?

Gray 10 theme

Is this issue related to a specific component? If so please give the page, artboard, and layer/symbol name.

component: Date picker
symbol: "date picker / 02 single date calendar / medium / open"

What did you expect to happen? What happened instead? What would you like to see changed?

The following symbols should either have their background available as overrides:
"date picker / pieces / previous month / 01 enabled"
"date picker / pieces / next month / 01 enabled"

or set with a transparent background to match the "date picker / pieces / calendar" background.

Is this issue being filed based on a discrepancy between the website/code and the kit? If so what is the inconsistency?

The website live demo is incorrectly showing the Date picker open state with a white background when the input is grey
https://www.carbondesignsystem.com/components/date-picker/usage/

Screen Shot 2021-04-16 at 9 03 53

It should match the React Storybook correct example where both the input and the open calendar are using the same background color.
https://react.carbondesignsystem.com/?path=/story/components-datepicker--single

Screen Shot 2021-04-19 at 8 31 30

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

IBM TRIRIGA

@stale
Copy link

stale bot commented Jun 22, 2021

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Jun 22, 2021
@stale
Copy link

stale bot commented Jul 29, 2021

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale
Copy link

stale bot commented Apr 17, 2022

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Apr 17, 2022
@laurenmrice
Copy link
Member

This has been resolved, going to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants