Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi select] Inconsistent spacing between closed multi-select and open multi-select dropdown in White theme #391

Closed
nathaniel-qin opened this issue Nov 19, 2020 · 2 comments

Comments

@nathaniel-qin
Copy link

nathaniel-qin commented Nov 19, 2020

Detailed description

Describe in detail the issue you're having. Please include whether or not this is part of Sketch Libraries or the larger Sketch Kit file.

What version of the Carbon Design System Kit are you using?

Last updated 1 minute ago.

Is this issue related to a specific component? If so please give the page, artboard, and layer/symbol name.

Carbon Design System (White theme) / dropdown / 03 multi-select / medium / 01 label / regular / closed
Carbon Design System (White theme) / dropdown / 03 multi-select / medium / 01 label / regular / open

Carbon Design System (White theme) / dropdown / 03 multi-select / medium / 01 label / filterable / closed
Carbon Design System (White theme) / dropdown / 03 multi-select / medium / 01 label / filterable / open

What did you expect to happen? What happened instead? What would you like to see changed?

I expected both components to have the same spacing between the label and the dropdown, but it's 8px when closed and 5px when opened.

Is this issue being filed based on a discrepancy between the website/code and the kit? If so what is the inconsistency?

No

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

HDM > Db2. No

Steps to reproduce the issue

  1. Find the components in the Carbon Design System (White theme) sketch kit.
  2. Observe the inconsistent spacing

Additional information

image
image

@nathaniel-qin nathaniel-qin changed the title White theme: Inconsistent spacing between closed multi-select and open multi-select dropdow White theme: Inconsistent spacing between closed multi-select and open multi-select dropdown Nov 19, 2020
@nathaniel-qin nathaniel-qin changed the title White theme: Inconsistent spacing between closed multi-select and open multi-select dropdown [Multi select] Inconsistent spacing between closed multi-select and open multi-select dropdown in White theme Nov 19, 2020
@laurenmrice laurenmrice self-assigned this Nov 23, 2020
@laurenmrice
Copy link
Member

laurenmrice commented Nov 23, 2020

  • White theme
  • Gray 10 theme
  • Gray 90 theme
  • Gray 100 theme

@laurenmrice
Copy link
Member

I checked all themes and fixed the label spacing bugs 👍🏻. Will be in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants