Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Shell - Left Panel - Gray 90 - colours #356

Closed
xkov opened this issue Aug 28, 2020 · 5 comments
Closed

UI Shell - Left Panel - Gray 90 - colours #356

xkov opened this issue Aug 28, 2020 · 5 comments

Comments

@xkov
Copy link

xkov commented Aug 28, 2020

Detailed description

In Sketch, the group of items in UI Shell > Left Panel > Side Nav and Side Rail have unexpected colours. I expected them to have dark backgrounds and light foregrounds in the Gray 90 and Gray 100 themes, but they are light. They seem similar to the light theme versions.

What version of the Carbon Design System Kit are you using?

The latest, updated 11 Aug 2020 (I think it's 10.10)

Is this issue related to a specific component? If so please give the page, artboard, and layer/symbol name.

Yes. UI Shell > Left Panel > Side Nav and Side Rail

What did you expect to happen? What happened instead? What would you like to see changed?

The symbol items I place on my Sketch (v68.1) artboard I expected to be dark themed.
The items are light themed.
Appropriate dark theme colours applied.

Is this issue being filed based on a discrepancy between the website/code and the kit? If so what is the inconsistency?

I have seen examples on Carbon gallery web pages, where on a dark themed design the UI Shell Side Rail and Side Nav follow the general dark theme.

Steps to reproduce the issue

  1. In Sketch, go to
    Insert > Symbols > Carbon Design System (Gray 90 theme) > ui shell > left panel > group > side rail > open
    or
    Insert > Symbols > Carbon Design System (Gray 90 theme) > ui shell > left panel > group > side-nav > default
    (or similar items there)
    and add the symbol to the artboard
  2. Observe the colours are in a light theme

Add labels

libraries kit: sketch theme color

Screen Shot 2020-08-28 at 10 34 35 am

@stale
Copy link

stale bot commented Oct 1, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Oct 1, 2020
@stale
Copy link

stale bot commented Nov 5, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Nov 5, 2020
@stale
Copy link

stale bot commented Dec 19, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Dec 19, 2020
@stale
Copy link

stale bot commented Mar 10, 2021

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Mar 10, 2021
@laurenmrice
Copy link
Member

The Carbon UI Shell does not have themes right now but is something we plan to implement for our next major release in June. This is an open issue for the different possible theme options carbon-design-system/carbon#4839.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants