Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elements] color token hover-primary-text wrong value in dark themes #321

Closed
2 tasks done
laurenmrice opened this issue May 6, 2020 · 3 comments
Closed
2 tasks done

Comments

@laurenmrice
Copy link
Member

laurenmrice commented May 6, 2020

Detailed description

The values for the color token hover-primary-text is wrong in the dark theme kits. Should be Blue 30, not Blue 70 hover.

  • Need to change in the color styles
  • Need to also change on website (Color page, Usage tab)

What version of the Carbon Design System Kit are you using?

Sketch Cloud (on the newest update)

Is this issue being filed based on a discrepancy between the website/code and the kit? If so what is the inconsistency?

The website Color page, Usage tab also needs to updated with Blue 30 as the dark theme values for this color token.

@laurenmrice laurenmrice changed the title [elements] color token hover-pirmary-text wrong value in dark themes [elements] color token hover-primary-text wrong value in dark themes May 27, 2020
@stale
Copy link

stale bot commented Jun 26, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Jun 26, 2020
@stale
Copy link

stale bot commented Aug 1, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@laurenmrice
Copy link
Member Author

Fixed! Attached PR will solve the website inconsistency 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant