Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inline notification story #1565

Open
davidnixon opened this issue Jan 16, 2024 · 4 comments
Open

Improve inline notification story #1565

davidnixon opened this issue Jan 16, 2024 · 4 comments
Assignees
Labels

Comments

@davidnixon
Copy link
Collaborator

Title line template: [Improve inline notification story]: Add migration notes and slots examples

Detailed description

Inline Notification story docs should add migration notes similiar to inline loading to call out the removal of the v-html support for the subtitle.

https://vue.carbondesignsystem.com/?path=/story/component-cvinlinenotification--info

Steps to reproduce the issue

  1. Step one
  2. Step two
  3. Step three
  4. etc.

Additional information

This displayed correctly in Vue2 components
image

Example of updated usage:
In Vue 2

      <cv-inline-notification
        style="margin: 0"
        kind="warning"
        title="Warning"
        :sub-title="getLink"
        :low-contrast="true"
        :hide-close-button="true"
      />

Where "getLink" returned an HTML string

In Vue 3

      <cv-inline-notification
        style="margin: 0"
        kind="warning"
        title="Warning"
        :low-contrast="true"
        :hide-close-button="true"
      >
        <template #sub-title>
          Requires you to submit a request for use.<br />
          <a target="_blank" :href="item.request_link">Link to request form</a>
        </template>
      </cv-inline-notification>
@LucasGazetta
Copy link

Hey, can i give it a look?

@davidnixon
Copy link
Collaborator Author

That would be great! Thanks!

Copy link

This issue has been marked as stale because it has required additional
info or a response from the author for over 14 days. When you get the
chance, please comment with the additional info requested.
Otherwise, this issue will be closed in 14 days.

@github-actions github-actions bot added the stale 🍞 No recent activity label Jun 10, 2024
@davidnixon davidnixon removed the stale 🍞 No recent activity label Jun 18, 2024
Copy link

github-actions bot commented Jul 8, 2024

This issue has been marked as stale because it has required additional
info or a response from the author for over 14 days. When you get the
chance, please comment with the additional info requested.
Otherwise, this issue will be closed in 14 days.

@github-actions github-actions bot added the stale 🍞 No recent activity label Jul 8, 2024
@davidnixon davidnixon removed the stale 🍞 No recent activity label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants