Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppScan reports issue with innerHTML #1541

Open
davidnixon opened this issue Oct 9, 2023 · 2 comments
Open

AppScan reports issue with innerHTML #1541

davidnixon opened this issue Oct 9, 2023 · 2 comments

Comments

@davidnixon
Copy link
Collaborator

This is a tricky one to fix dur to the testing required to make sure nothing is broken.

This affects _CvSvg and CvDatePicker. AppScan report "Insecure Use of InnerHTML or OuterHTML"
This is a false positive report but it would be best to remove reference to innerHTML if possible.

In certain cases CvDatePicker, which is a wrapper around flatpicker, is removing white space from the innerHTML with

currentItem.innerHTML = currentItem.innerHTML.replace(/\s+/g, '');

This needs some testing to see if this can just be removed.

In _CvSvg the svg content is added to the component via innerHTML. There is probably a clearer way to do this.

Copy link

This issue has been marked as stale because it has required additional
info or a response from the author for over 14 days. When you get the
chance, please comment with the additional info requested.
Otherwise, this issue will be closed in 14 days.

@github-actions github-actions bot added the stale 🍞 No recent activity label Jun 10, 2024
@davidnixon davidnixon removed the stale 🍞 No recent activity label Jun 18, 2024
Copy link

github-actions bot commented Jul 8, 2024

This issue has been marked as stale because it has required additional
info or a response from the author for over 14 days. When you get the
chance, please comment with the additional info requested.
Otherwise, this issue will be closed in 14 days.

@github-actions github-actions bot added the stale 🍞 No recent activity label Jul 8, 2024
@davidnixon davidnixon removed the stale 🍞 No recent activity label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant