Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox - filter search is inconsistent between single and multi-select versions #1701

Open
yashgarg17 opened this issue Jan 15, 2021 · 2 comments
Labels
component: Combobox For Combobox issues style Might need a change in carbon-components CSS

Comments

@yashgarg17
Copy link

yashgarg17 commented Jan 15, 2021

Title line template: [Title]: Brief description

For the Combobox component, there is an inconsistency observed while searching for options between single and multi-select versions.

Detailed description

Describe in detail the issue you're having.
There are primarily 2 versions of the Combobox component are available -
single-selection - https://angular.carbondesignsystem.com/?path=/story/components-combobox--basic
multi-selection - https://angular.carbondesignsystem.com/?path=/story/components-combobox--multi-select

We have observed inconsistent behaviour while applying same filter in both the versions.
In case of single-select, if the search value is not present, then all the options are displayed -

image

But in case of multi-select, if the searched value is not present, then no options are listed -

image

Filtering should be consistent across the versions.

Is this a feature request (new component, new icon), a bug, or a general issue?
BUG

Is this issue related to a specific component?
It is specific to Combobox component

What did you expect to happen? What happened instead? What would you like to see changed?

Expected behaviour -
If the searched value is not matching with any of the options available, then it should show nothing as in case of multi-select version of Combobox component

Actual behaviour -
In case of single-select, if the search value is not present, then all the options are displayed

What browser are you working in?
Chrome

What version of the Carbon Design System are you using?
4.36.1

What offering/product do you work on? Any pressing ship or release dates we should be aware of?
IBM Cloud Brokerage - Cost and Asset Management

Steps to reproduce the issue

  1. Go to https://angular.carbondesignsystem.com/?path=/story/components-combobox--basic
  2. Search for any text which is not matching with any of the options. For example - test
  3. Observe that all the available options are displayed, even though test is not matching with any of the options

image

  1. Now go to https://angular.carbondesignsystem.com/?path=/story/components-combobox--multi-select
  2. Search for any text which is not matching with any of the options. For example - test
  3. Observe that no option is displayed, because test is not matching with any of the options

image

@yashgarg17 yashgarg17 changed the title ComboBox - filter search is inconsistent between single and multi-select versions Combobox - filter search is inconsistent between single and multi-select versions Jan 15, 2021
@zvonimirfras
Copy link
Member

Hi @yashgarg17, thank you for noticing.

The same behavior is observable in the reference implementation (single, multi), so that's by design.

If you think this should be changed, open an issue in https://github.com/carbon-design-system/carbon and reopen this issue with a link to the issue you opened there. :)

@yashgarg17
Copy link
Author

As per your suggestion , I have opened an issue in https://github.com/carbon-design-system/carbon which can be found at -
carbon-design-system/carbon#7589

Since the behavior is inconsistent, therefore reopening the defect

@zvonimirfras zvonimirfras reopened this Jan 18, 2021
@zvonimirfras zvonimirfras added style Might need a change in carbon-components CSS component: Combobox For Combobox issues labels Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Combobox For Combobox issues style Might need a change in carbon-components CSS
Projects
None yet
Development

No branches or pull requests

2 participants