feat(core): add support for horizontal bar charts #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #133 |
|
Deploy preview for carbon-charts-vue ready! Built with commit 08cc59c |
|
Deploy preview for carbon-charts-angular ready! Built with commit 08cc59c https://deploy-preview-415--carbon-charts-angular.netlify.com |
|
Deploy preview for carbon-charts-react ready! Built with commit 08cc59c |
|
Deploy preview for carbon-charts-core ready! Built with commit 6150d52 |
…on-charts into horizontal-bar-support
cal-smith
reviewed
Dec 4, 2019
cal-smith
reviewed
Dec 9, 2019
cameroncalder
previously approved these changes
Dec 10, 2019
Co-Authored-By: Cal Smith <[email protected]>
…s into horizontal-bar-support
…s into horizontal-bar-support
…s into horizontal-bar-support
…s into horizontal-bar-support
cal-smith
suggested changes
Jan 20, 2020
…s into horizontal-bar-support
zvonimirfras
suggested changes
Jan 21, 2020
cal-smith
previously approved these changes
Jan 21, 2020
zvonimirfras
suggested changes
Jan 21, 2020
zvonimirfras
approved these changes
Jan 21, 2020
cal-smith
approved these changes
Jan 21, 2020
4 tasks
theiliad
added a commit
to theiliad/carbon-charts
that referenced
this pull request
May 17, 2021
…em#415) * feat(core): add support for horizontal bar charts * add stories for horizontal bar * add horizontal discrete bar chart * add vue and angular stories * update zero-line transition * Update packages/core/src/components/graphs/bar-stacked.ts Co-Authored-By: Cal Smith <[email protected]> * enable switching orientations for grouped bar without duplicating draw logic * fix lint errors * draw simple bars in horizontal & vertical orientations * draw stacked bars regardless of 2D orientation * add orientation support for time-series stacked bar charts * use the calculated bar width in all 3 bar types * add requested PR changes * fix lint error * fix lint error * fix tests * fix lint error * fix tests tsconfig issue * add knobs to all stories * add requested PR changes * code style changes * code style fixes Co-authored-by: Eliad Moosavi <[email protected]> Co-authored-by: Cal Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Demo screenshots or recording
Horizontal Simple Bar
Horizontal Stacked Bar
Update the multipoint ordering on tooltip for horizontal stacked bar
To-do
Review checklist (for reviewers only)