Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CUSTOM ToolbarControls render as enabled when shouldBeDisabled returns true #1864

Open
2 of 6 tasks
justindm234 opened this issue Jul 1, 2024 · 0 comments
Open
2 of 6 tasks

Comments

@justindm234
Copy link

Relevant package(s)

  • @carbon/charts
  • @carbon/charts-svelte
  • @carbon/charts-react
  • @carbon/charts-angular
  • @carbon/charts-vue
  • Documentation website

Carbon Charts Version

1.17.2

Which bundler are you using?

Webpack

What happened and what did you expect to happen?

What happened...

  • Disabled CUSTOM ToolbarControl icon buttons and overflow menu items render as enabled

What did you expect...

  • Disabled CUSTOM ToolbarControl icon buttons and overflow menu items should render as disabled - button and toolbar markup should have [disabled=false] etc for screen readers; should render as disabled @carbon/react components (disabled hover icon/styling)

Steps to reproduce

  • Define a CUSTOM ToolbarControl whose shouldBeDisabled function returns true

Chart data and options (automatically formatted so no need for backticks)

See StackBlitz repro

JavaScript console or build output (if relevant)

See StackBlitz repro

StackBlitz repro

https://stackblitz.com/edit/react-ya7h72?file=src%2Foptions.js

IBM Application/Team (if relevant)

IBM Z Hardware Management Console

What priority level would this be in your opinion?

P1 (High)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant