fix(core angular): Remove demo folders from published packages

Remove demo folders from published packages
carbon-design-system · Aug 31, 2018 · 5e3c556 · 5e3c556
1 parent 2f8bb5f
commit 5e3c556
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.travis/after_success.sh b/.travis/after_success.sh
@@ -23,8 +23,6 @@ if [[ $TRAVIS_BRANCH == 'master' ]]; then
   git config credential.helper "store --file=.git/credentials"
   echo "https://${GH_TOKEN}:@github.com" > .git/credentials 2>/dev/null
 
-  lerna publish --conventional-commits --yes
-
   # Generate all assets
   # needed for push to gh-page
   mkdir pages
@@ -36,10 +34,17 @@ if [[ $TRAVIS_BRANCH == 'master' ]]; then
   npm run demo:build
   typedoc --out ./demo/bundle/documentation ./src/index.ts
   cp -a demo/bundle/. ../../pages
+  rm -rf demo
 
   cd ../angular/demo
   npm run build-storybook
   cp -a storybook-dist/. ../../../pages/angular
+  cd ..
+  rm -rf demo
+  cd ../..
+
+  # Perform git & npm publish
+  lerna publish --conventional-commits --yes
 fi
 
 if [[ echo $TRAVIS_BRANCH | grep "^v[0-9]\+\.[0-9]\+\.[0-9]\+\$" ]]; then

diff --git a/packages/angular/demo/src/index.html b/packages/angular/demo/src/index.html
@@ -2,7 +2,7 @@
 <html lang="en">
   <head>
     <meta charset="utf-8">
-    <title>Demo</title>
+    <title>Carbon Charts - Angular</title>
     <base href="/">
 
     <meta name="viewport" content="width=device-width, initial-scale=1">

diff --git a/packages/core/src/services/patterns.ts b/packages/core/src/services/patterns.ts
@@ -82,6 +82,7 @@ export default class PatternsService {
 				const patternElement = mountedSVG.querySelector("pattern");
 				patternElement.id = `carbon-${chartContainerID}-pattern-${id}`;
 
+				// Remove all IDs to avoid duplicate IDs (accessibility violation)
 				mountedSVG.querySelector("g").removeAttribute("id");
 
 				// Apply fills to everything
@@ -94,12 +95,14 @@ export default class PatternsService {
 						element.style.fill = "transparent";
 					}
 
+					// Remove ID to avoid duplicate IDs (accessibility violation)
 					element.removeAttribute("id");
 					element.removeAttribute("class");
 				});
 
 				const allRectsInsideSVG = Array.prototype.slice.call(mountedSVG.querySelectorAll("rect"));
 				allRectsInsideSVG.forEach(rectElement => {
+					// Remove all IDs to avoid duplicate IDs (accessibility violation)
 					rectElement.removeAttribute("id");
 				});