fix(packages/core/src/line-chart.ts): Fix tooltips bug #89: Fix impor…

…ts and addDataPointEventListene Bug #89: Tooltips for Stacked Bar & Line show onClick
carbon-design-system · Nov 17, 2018 · 5a63f94 · 5a63f94
1 parent b298dcf
commit 5a63f94
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 22 deletions.
diff --git a/packages/core/src/line-chart.ts b/packages/core/src/line-chart.ts
@@ -1,5 +1,5 @@
 // D3 Imports
-import { select, selectAll, mouse } from "d3-selection";
+import { select, mouse } from "d3-selection";
 import { line } from "d3-shape";
 
 import { BaseAxisChart } from "./base-axis-chart";
@@ -206,12 +206,11 @@ export class LineChart extends BaseAxisChart {
 		super.resizeChart();
 	}
 
-
 	addDataPointEventListener() {
 		const self = this;
 		const { accessibility } = this.options;
 
-		this.svg.selectAll("gLines")
+		this.svg.selectAll("circle.dot")
 			.on("click", function(d) {
 				self.dispatchEvent("line-onClick", d);
 			})
@@ -235,23 +234,6 @@ export class LineChart extends BaseAxisChart {
 				const { strokeWidth, strokeWidthAccessible } = Configuration.lines.points.mouseout;
 				select(this)
 					.attr("stroke-width", accessibility ? strokeWidthAccessible : strokeWidth)
-					.attr("stroke", accessibility ? self.colorScale[d.datasetLabel](d.label) : "none")
-					.attr("stroke-opacity", Configuration.lines.points.mouseout.strokeOpacity);
-
-				self.hideTooltip();
-			});
-
-		this.svg.selectAll("circle.dot")
-			.on("mouseover", function(d) {
-				select(this)
-					.attr("stroke", self.colorScale[d.datasetLabel](d.label))
-					.attr("stroke-opacity", Configuration.lines.points.mouseover.strokeOpacity);
-
-				self.showTooltip(d, this);
-				self.reduceOpacity(this);
-			})
-			.on("mouseout", function(d) {
-				select(this)
 					.attr("stroke", self.colorScale[d.datasetLabel](d.label))
 					.attr("stroke-opacity", Configuration.lines.points.mouseout.strokeOpacity);
 

diff --git a/packages/core/src/stacked-bar-chart.ts b/packages/core/src/stacked-bar-chart.ts
@@ -1,5 +1,5 @@
 // D3 Imports
-import { select, selectAll, mouse } from "d3-selection";
+import { select, mouse } from "d3-selection";
 import { stack } from "d3-shape";
 import { max } from "d3-array";
 
@@ -241,6 +241,5 @@ export class StackedBarChart extends BaseAxisChart {
 
 				self.hideTooltip();
 			});
-
 	}
 }