Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate traffic_rule label to custom metrics when the router timeout is reached #281

Open
krithika369 opened this issue Nov 4, 2022 · 0 comments

Comments

@krithika369
Copy link
Collaborator

A traffic rule label (traffic_rule) has been introduced in #280, which captures the selected rule on the mlp_turing_route_request_duration_ms and mlp_turing_turing_comp_request_duration_ms metrics, when the router has traffic rules enabled.

However, in a scenario where the overall timeout is reached on the router, the mlp_turing_turing_comp_request_duration_ms failure metric will not always capture the traffic_rule label. This is because, during context cancellation, the parent Fiber components may return first without waiting for the child component(s) to return and thus, the label set in the nested components may not be propagated upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant