Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-t option is used with tarFile and appToken #126

Open
fu-sen opened this issue Sep 13, 2022 · 1 comment
Open

-t option is used with tarFile and appToken #126

fu-sen opened this issue Sep 13, 2022 · 1 comment

Comments

@fu-sen
Copy link

fu-sen commented Sep 13, 2022

Got this when I looked at caprover deploy --help.

  -t, --tarFile <value>           tar file to be uploaded, must contain captain-definition file (env: CAPROVER_TAR_FILE)
  -i, --imageName <value>         image name to be deployed, it should either exist on server, or it has to be public, or on a private repository that CapRover has access to (env: CAPROVER_IMAGE_NAME)
  -t, --appToken <value>          app Token (env: CAPROVER_APP_TOKEN)

The -t option duplicates --tarFile and --appToken. This source part

https://github.com/caprover/caprover-cli/blob/master/src/commands/deploy.ts#L179-L204

-t now works for tarFile, since tarFile is at the top of the source.
Token does not work with -t, --appToken is always required. (This is the current workaround)

Which single letter option should be replaced.

@edson-gaspar
Copy link

This error caused me to lose almost a day of work, and I was on the verge of giving up on using this tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants