Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Type Hinting: dataprofiler/data_readers/ #610

Closed
taylorfturner opened this issue Aug 12, 2022 · 4 comments
Closed

Static Type Hinting: dataprofiler/data_readers/ #610

taylorfturner opened this issue Aug 12, 2022 · 4 comments
Assignees
Labels
New Feature A feature addition not currently in the library static_typing mypy static typing issues

Comments

@taylorfturner
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Improve the project in the area of

  • Make collaboration and code contribution easier
  • Getting started with the code when a contributor is new to the code base

Describe the outcome you'd like:
Utilizing types from mypy documentation for python3, implement type hinting in the dataprofiler/data_readers/ folder. In this case, because there are multiple files in the folder, at the very minimum the changes should be partitioned out into multiple Pull Requests (PRs). Potentially this could go so far as 1 PR --> 1 file update with type hints.

Additional context:

@taylorfturner taylorfturner added the New Feature A feature addition not currently in the library label Aug 12, 2022
@taylorfturner taylorfturner added the static_typing mypy static typing issues label Aug 12, 2022
@taylorfturner
Copy link
Contributor Author

Because this folder is so large, I recommend making more PRs that are smaller (3 - 4 files at a time / keep the net diff number lower when possible).

@taylorfturner
Copy link
Contributor Author

@Sanketh7 just these last three PRs and this will be complete? Is that right?

@Sanketh7
Copy link
Contributor

Sanketh7 commented Oct 6, 2022

@Sanketh7 just these last three PRs and this will be complete? Is that right?

There are 2 more files that need static typing but these are very short and I'll have a PR for them up soon.

@taylorfturner
Copy link
Contributor Author

All merged. Closing. Thanks @Sanketh7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A feature addition not currently in the library static_typing mypy static typing issues
Projects
None yet
Development

No branches or pull requests

5 participants