fix: select without columns from unknown entity #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
requested review from
danjoa,
johannes-vogel and
stewsk
as code owners
| @@ -249,7 +254,7 @@ class HANAService extends SQLService { | |||
| this.temporary = this.temporary || [] | |||
| this.temporaryValues = this.temporaryValues || [] | |||
|
|
|||
| const { limit, one, orderBy, expand, columns, localized, count, parent } = q.SELECT | |||
| const { limit, one, orderBy, expand, columns = ['*'], localized, count, parent } = q.SELECT | |||
There was a problem hiding this comment.
Is there a reason we do not need this for sqlite?
johannes-vogel
approved these changes
Feb 16, 2024
Merged
johannes-vogel
pushed a commit
that referenced
this pull request
Feb 16, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.6.2</summary> ## [1.6.2](db-service-v1.6.1...db-service-v1.6.2) (2024-02-16) ### Fixed * ** `infer`:** unique alias for scoped subqueries ([#465](#465)) ([5dbaa8e](5dbaa8e)) * Allow only for array of arrays as data for plain SQL ([#449](#449)) ([22e1c43](22e1c43)) * dont insert structured elements ([#461](#461)) ([f3f688d](f3f688d)) * ignore virtual keys in UPSERT([#463](#463)) ([49adbf3](49adbf3)) * INSERT entries containing undefined values ([#453](#453)) ([d3aad75](d3aad75)) * select without columns from unknown entity ([#466](#466)) ([eb857de](eb857de)) </details> <details><summary>sqlite: 1.5.1</summary> ## [1.5.1](sqlite-v1.5.0...sqlite-v1.5.1) (2024-02-16) ### Fixed * **`sqlite`:** Retain Error object for unique constraint violation ([#446](#446)) ([d27ee79](d27ee79)) </details> <details><summary>postgres: 1.5.1</summary> ## [1.5.1](postgres-v1.5.0...postgres-v1.5.1) (2024-02-16) ### Fixed * **`sqlite`:** Retain Error object for unique constraint violation ([#446](#446)) ([d27ee79](d27ee79)) </details> <details><summary>hana: 0.0.5</summary> ## [0.0.5](hana-v0.0.4...hana-v0.0.5) (2024-02-16) ### Fixed * **`sqlite`:** Retain Error object for unique constraint violation ([#446](#446)) ([d27ee79](d27ee79)) * **hana:** ensure the database connection does not enable auto commit ([#448](#448)) ([b2ca1da](b2ca1da)) * **hana:** Ensure xpr with logical operator to only contain comparisons ([#452](#452)) ([a2ecb22](a2ecb22)) * ignore virtual keys in UPSERT([#463](#463)) ([49adbf3](49adbf3)) * select without columns from unknown entity ([#466](#466)) ([eb857de](eb857de)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Merged
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.