chore: Remove classes with very few constants (#406)

Author: mofterdinger

cds-feature-attachments/src/main/java/com/sap/cds/feature/attachments/configuration/Registration.java

@@ -39,7 +39,6 @@
 import com.sap.cds.feature.attachments.service.malware.client.DefaultMalwareScanClient;
 import com.sap.cds.feature.attachments.service.malware.client.httpclient.MalwareScanClientProviderFactory;
 import com.sap.cds.feature.attachments.service.malware.client.mapper.DefaultMalwareClientStatusMapper;
-import com.sap.cds.feature.attachments.service.malware.constants.MalwareScanConstants;
 import com.sap.cds.services.ServiceCatalog;
 import com.sap.cds.services.cds.ApplicationService;
 import com.sap.cds.services.draft.DraftService;
@@ -91,7 +90,7 @@ public void eventHandlers(CdsRuntimeConfigurer configurer) {
 
 		// retrieve the service binding for the malware scanner service
 		List<ServiceBinding> bindings = environment.getServiceBindings()
-				.filter(b -> ServiceBindingUtils.matches(b, MalwareScanConstants.MALWARE_SCAN_SERVICE_LABEL)).toList();
+				.filter(b -> ServiceBindingUtils.matches(b, DefaultAttachmentMalwareScanner.MALWARE_SCAN_SERVICE_LABEL)).toList();
 		var binding = !bindings.isEmpty() ? bindings.get(0) : null;
 
 		// get HTTP connection pool configuration

cds-feature-attachments/src/main/java/com/sap/cds/feature/attachments/handler/common/ApplicationHandlerHelper.java

@@ -16,7 +16,6 @@
 import com.sap.cds.CdsDataProcessor.Filter;
 import com.sap.cds.CdsDataProcessor.Validator;
 import com.sap.cds.feature.attachments.generated.cds4j.sap.attachments.Attachments;
-import com.sap.cds.feature.attachments.handler.constants.ModelConstants;
 import com.sap.cds.reflect.CdsElement;
 import com.sap.cds.reflect.CdsEntity;
 import com.sap.cds.reflect.CdsStructuredType;
@@ -26,13 +25,15 @@
  * The class {@link ApplicationHandlerHelper} provides helper methods for the attachment application handlers.
  */
 public final class ApplicationHandlerHelper {
+	private static final String ANNOTATION_IS_MEDIA_DATA = "_is_media_data";
+	private static final String ANNOTATION_CORE_MEDIA_TYPE = "Core.MediaType";
 
 	/**
 	 * A filter for media content fields. The filter checks if the entity is a media entity and if the element has the
 	 * annotation "Core.MediaType".
 	 */
 	public static final Filter MEDIA_CONTENT_FILTER = (path, element, type) -> isMediaEntity(path.target().type())
-			&& hasElementAnnotation(element, ModelConstants.ANNOTATION_CORE_MEDIA_TYPE);
+			&& hasElementAnnotation(element, ANNOTATION_CORE_MEDIA_TYPE);
 
 	/**
 	 * Checks if the data contains a content field.
@@ -65,7 +66,7 @@ public static void callValidator(CdsEntity entity, List<CdsData> data, Filter fi
 	 * @return <code>true</code> if the entity is a media entity, <code>false</code> otherwise
 	 */
 	public static boolean isMediaEntity(CdsStructuredType baseEntity) {
-		return baseEntity.getAnnotationValue(ModelConstants.ANNOTATION_IS_MEDIA_DATA, false);
+		return baseEntity.getAnnotationValue(ANNOTATION_IS_MEDIA_DATA, false);
 	}
 
 	public static boolean doesContentIdExistsBefore(Map<?, Object> existingData) {

cds-feature-attachments/src/main/java/com/sap/cds/feature/attachments/handler/constants/ModelConstants.java

@@ -34,6 +34,8 @@
  */
 public class DefaultAttachmentMalwareScanner implements AttachmentMalwareScanner {
 
+	public static final String MALWARE_SCAN_SERVICE_LABEL = "malware-scanner";
+
 	private static final Logger logger = LoggerFactory.getLogger(DefaultAttachmentMalwareScanner.class);
 	private final PersistenceService persistenceService;
 	private final AttachmentService attachmentService;

cds-feature-attachments/src/main/java/com/sap/cds/feature/attachments/service/malware/DefaultAttachmentMalwareScanner.java

@@ -8,7 +8,7 @@
 
 import org.apache.http.client.HttpClient;
 
-import com.sap.cds.feature.attachments.service.malware.constants.MalwareScanConstants;
+import com.sap.cds.feature.attachments.service.malware.DefaultAttachmentMalwareScanner;
 import com.sap.cds.services.environment.CdsProperties.ConnectionPool;
 import com.sap.cloud.environment.servicebinding.api.ServiceBinding;
 import com.sap.cloud.sdk.cloudplatform.connectivity.DefaultHttpClientFactory;
@@ -36,7 +36,7 @@ public MalwareScanClientProviderFactory(ServiceBinding binding, ConnectionPool c
 			var url = (String) credentials.get(VALUE_URL);
 			var serviceUrl = URI.create(url + SCAN_ENDPOINT).normalize();
 			var basic = new BasicCredentials((String) credentials.get(VALUE_USERNAME), (String) credentials.get(VALUE_PASSWORD));
-			var destination = DefaultHttpDestination.builder(serviceUrl).name(MalwareScanConstants.MALWARE_SCAN_SERVICE_LABEL)
+			var destination = DefaultHttpDestination.builder(serviceUrl).name(DefaultAttachmentMalwareScanner.MALWARE_SCAN_SERVICE_LABEL)
 					.basicCredentials(basic).build();
 
 			DefaultHttpClientFactoryBuilder builder = DefaultHttpClientFactory.builder();