Support function timeout via async.timeout wrapper #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still 💯 on this, but master has changed significantly. Can you re-do the work? It also would be nice if you added a |
|
Sure, I'll redo this and add a mocha test as well 👍 |
ajfranzoia
force-pushed
the
support-async-timeout
branch
from
af292d7
to
0d87dd0
Compare
|
Re-did this to support the new master and added a mocha test. I did some refactoring as well to the original code to make it clearer. |
aearly
added a commit
that referenced
this pull request
Mar 7, 2016
Support function timeout via async.timeout wrapper
|
This is a nice feature! Probably add some docs of it? :) |
|
Added docs via #1051. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements timeout feature discussed in #1007.
Follows @aearly advice on using a wrapper around the asynchronous functions. I changed the function arguments' order to match
setTimeoutsignature.If there are any mistakes or things that need modification, just let me know.
I can add the readme info if this looks good.