Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WG proposal: Make secondary buttons dark #4753

Open
lyubomir-popov opened this issue Apr 28, 2023 · 5 comments
Open

WG proposal: Make secondary buttons dark #4753

lyubomir-popov opened this issue Apr 28, 2023 · 5 comments
Assignees
Labels
Blocked ⛔ Vanilla WG Task owned by Vanilla Working Group WG: Proposal Working group proposals

Comments

@lyubomir-popov
Copy link
Contributor

On the new paper backgrouind, bordered buttons look strange. How about making them dark:

image

@lyubomir-popov lyubomir-popov added the WG: Proposal Working group proposals label Apr 28, 2023
@danielmutis
Copy link

From WG:

  • The black buttons look as if they have more prominence than the primary button. They should have less contrast than the primary one.
  • We need to investigate whether this would break anything since buttons are one of the most used components.
  • Explore more options. What is the rationale behind this change/problem? What is the issue with the current button?

@danielmutis
Copy link

WG:

  • Does this fit the use case of the application layout? Are there any concerns if the black button looks more prominent than the primary one on an application?
  • @lyubomir-popov to discuss with research how we can evaluate the adequacy of black as a colour on the secondary button.
  • @lyubomir-popov to explore what would happen on dark themes as well.

@danielmutis
Copy link

danielmutis commented Sep 6, 2023

@lidia-luna
Copy link

We didn't have an ab test ran for this, but the heatmap (included) for this page with the black button looks quite ordinary, and doesn't suggest that the black button is an issue.
pro increase traffic to why-pro page - Control, Desktop, heatmap, 4-30-2024
Here is also the heatmap without a black button (but with different copy too) for reference
Ubuntu Pro  June 2023 - Desktop, Heatmap, 06-08-23

Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-14341.

This message was autogenerated

@bartaz bartaz added P3 Needs decision Needs team agreement in terms of triaging. Vanilla WG Task owned by Vanilla Working Group and removed P3 Needs decision Needs team agreement in terms of triaging. labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked ⛔ Vanilla WG Task owned by Vanilla Working Group WG: Proposal Working group proposals
Projects
None yet
Development

No branches or pull requests

4 participants