Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip description read out twice by screen reader #4240

Open
bethcollins92 opened this issue Jan 12, 2022 · 2 comments
Open

Tooltip description read out twice by screen reader #4240

bethcollins92 opened this issue Jan 12, 2022 · 2 comments
Labels
Accessibility P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Priority: Medium Triaged: new architecture Triaged, to be addressed in new architecture of the design system

Comments

@bethcollins92
Copy link
Contributor

Describe the bug

First the button text is read out, then additional description (aria-describedby). The additional description is being read out twice because it's placed inside of the button and is part of the button text content.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://vanillaframework.io/docs/patterns/tooltips
  2. Activate VoiceOver
  3. Allow VoiceOver to read through tooltips and see how the text is read out twice

Expected behavior

The description should only be read out twice.

Additional context

Some solutions were suggested by @petermakowski

  1. Move span outside the button
<button class="p-tooltip" aria-describedby="default-tooltip">
  Bottom left
</button>
<span class="p-tooltip__message" role="tooltip" id="default-tooltip">Product name to be displayed on the storefront.</span>
  1. Try adding aria-hidden="true" to the tooltip span
<button class="p-tooltip" aria-describedby="default-tooltip">
  Bottom left
  <span class="p-tooltip__message" role="tooltip" id="default-tooltip" aria-hidden="true">Product name to be displayed on the storefront.</span>
</button>
@bartaz
Copy link
Member

bartaz commented Sep 23, 2024

Triage: We have detached tooltips available (that use option 1), option 2 feels bit risky as it may end up hiding tooltip from screen reader.

Probably not worth investing time now in v4, but for consideration in new architecture.

@bartaz bartaz added Triaged: v4 Triaged, to be implemented as part of Vanilla v4 Triaged: new architecture Triaged, to be addressed in new architecture of the design system labels Sep 23, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15188.

This message was autogenerated

@bartaz bartaz added P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). and removed Triaged: v4 Triaged, to be implemented as part of Vanilla v4 labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Priority: Medium Triaged: new architecture Triaged, to be addressed in new architecture of the design system
Projects
None yet
Development

No branches or pull requests

3 participants