Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The table in the what's new page is to tight on small screens #4238

Open
anthonydillon opened this issue Jan 11, 2022 · 7 comments
Open

The table in the what's new page is to tight on small screens #4238

anthonydillon opened this issue Jan 11, 2022 · 7 comments
Labels
P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Priority: Medium Triaged: v4 Triaged, to be implemented as part of Vanilla v4

Comments

@anthonydillon
Copy link
Contributor

Describe the bug

The key information on the what's new page is not accessible on small screens.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://vanillaframework.io/docs/whats-new on a phone
  2. See the version and other important information is truncated

Expected behavior
I should be able to see the all the information as it's key content.

Screenshots
Screenshot_20220111-235118.jpg

Additional context

The status key below is easy to read and looks nice (if that helps at all)

@elioqoshi
Copy link

@lyubomir-popov @bartaz quick draft. Would it be structurally okay / possible to merge the status and version values as part of the component? They feel more like labels than needing their own column: grafik.png

Alternatively we could include them in the table from the start in this manner?

Anyhow, quick two options with 1 having the description underneath (not sure if this is possible as part of a table component or whether that's the right approach though).

2 merges status and version into the component field which I think could work out better.

@lyubomir-popov
Copy link
Contributor

What's the point of the version column? We have one table per release, so you can remove the version column altogether.

@elioqoshi
Copy link

elioqoshi commented Jan 28, 2022

Good point. Not sure how it ended up there or whether it was automatical. Thought there might be some sub-version releases which might be relevant?

Regardless, even if that's removed there is still space lacking

@cristinadresch
Copy link

@bartaz any thoughts?

@bartaz
Copy link
Member

bartaz commented Feb 2, 2022

@elioqoshi

Overall I think version column is valuable, while we keep separate table for latest release, we do merge all previous releases into one long table, like here with 2.0:

Screenshot 2022-02-02 at 12 00 57

It is valuable to have this version information. While not ideal, we probably can hide version on small screens (because it's definitely supplementary information).

Visually I like your proposal of having notes below rest of the data, but I don't think it would be easily achievable with HTML table now.

Second option to merge status label and version into one cell seems interesting compromise.

The issue is from implementation point of view we don't have much flexibility to change table layout on different screen sizes, so we would need to explore that.

@bartaz
Copy link
Member

bartaz commented Sep 23, 2024

Triage: Low effort, low impact: As a quick fix we could apply the horizontal scroll as in other places in the docs.

@bartaz bartaz added P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4 labels Sep 23, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15186.

This message was autogenerated

@bartaz bartaz removed their assignment Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Priority: Medium Triaged: v4 Triaged, to be implemented as part of Vanilla v4
Projects
None yet
Development

No branches or pull requests

5 participants