ui: add Lazy loading for images>1MB #14448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
codewithnick is not a collaborator of the repo |
|
Hi @codewithnick, thanks for your contribution and sorry for the delayed reply. Would you be able to rebase this PR please and we can merge it? |
inital loading of hompage was loading around 9MB of resources. By lazy loading images we can reduce the intial loading by 5-6 MB.
codewithnick
force-pushed
the
improving-homepage-loadtime
branch
from
c4aca41 to
0a83735
Compare
|
hi @petesfrench I have updated the pr ,please lmk if any other changes are required |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14448 +/- ##
=======================================
Coverage 69.76% 69.76%
=======================================
Files 120 120
Lines 3426 3426
Branches 1181 1181
=======================================
Hits 2390 2390
Misses 1012 1012
Partials 24 24
|
petesfrench
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inital loading of hompage was loading around 9MB of resources.
By lazy loading images we can reduce the intial loading by 5-6 MB.
Done
QA
./run serveordotrunIssue / Card
Partially Fixes: #14443
Screenshots
[If relevant, please include a screenshot.]
before
after
Help
QA steps - Commit guidelines