-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing of storage constraints fails #1093
Parsing of storage constraints fails #1093
Comments
upgrade juju dependencies: - juju-agent 3.5.3 for CI pipeline - juju 3.5.0 in pyproject.toml (cannot be upgraded to 3.5.2 due to juju/python-libjuju#1093)
Encountered the same issue. The reason I suspect is that: #1053 expects to parse storage (in the
However, the
client.Constraints returns a custom object which is incompatible with the expected type in |
I do have the same issue on mongodb operator with a tests similar to @reneradoi |
With the last libjuju version (3.5.2), there is a bug when trying to deploy charms with custom storage (juju/python-libjuju#1093) This pins the libjuju version until it's fixed
This affects postgreSQL charms as well, exact same issue. |
Description
Hi Team!
After upgrading our libs to 3.5.2 one of our integration test fails with this error:
This is presumably due to #1053, which added parsing the storage constraints by applying
re.finditer()
on the given constraints. But as some of these (e.g. size) are integers and no strings, this fails.We define the storage constraints like this:
storage = {"opensearch-data": {"pool": "opensearch-pool", "size": 2048}}
This cannot be changed to string as per https://github.com/juju/python-libjuju/blob/main/juju/client/_definitions.py#L6531-L6532.Urgency
Annoying bug in our test suite
Python-libjuju version
3.5.2.0
Juju version
3.4.3, 3.5.3
Reproduce / Test
The text was updated successfully, but these errors were encountered: