fix the linker error on ubuntu 24.04 #3559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3559 +/- ##
==========================================
- Coverage 88.88% 88.84% -0.04%
==========================================
Files 254 254
Lines 14222 14222
==========================================
- Hits 12641 12636 -5
- Misses 1581 1586 +5 ☔ View full report in Codecov by Sentry. |
georgeliao
force-pushed
the
fix_linker_error_ubuntu_24.04
branch
from
23dbd39
to
cbafad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3558
A minimalistic example to reproduce this is to have an executable in Multipass CMake environment links to
Qt6::Networkandsshwheresshtarget is built by the git submodule library libssh of multipass.The problem here is that the executable links to
libQt6Network.so.6.4.2->libcurl-gnutls.so.4->libssh.so.4and 3rd-party libssh. So there are two libssh shared libraries linked to the same executable. Symbol versioning is a mechanism used in shared libraries to manage changes in the library API over time. In this case, the system lissh has the symbol version that linker is looking for but 3rd-party does not have. Besides, the linker apparently is looking into the 3rd-party libssh for the functions he needs as opposed to the system libssh.So one possible fix for this is to disambiguate the double libssh libraries by changing the 3rd-party libssh library from shared library to static library.